Skip to content

[CB] [Serve] Fix broken serve tests#43594

Merged
ArthurZucker merged 6 commits intomainfrom
fix-cb-serve
Jan 30, 2026
Merged

[CB] [Serve] Fix broken serve tests#43594
ArthurZucker merged 6 commits intomainfrom
fix-cb-serve

Conversation

@remi-or
Copy link
Collaborator

@remi-or remi-or commented Jan 29, 2026

This PR fixes two issues related to CB and serve:

  • when the max_length argument as set to None when creating a request, CB had an error because it always expected max_length to be an int. This is now an expected behavior, and we have a hidden variable to avoid checking if the variable is None
  • the CB streamer did not yield the last generated token when the request finished. This was not an issue before the last PR, because the result of each request was yielded twice (with the same amount of tokens). Now that this is fixed, it revealed the bug related to the streamer, which is now fixed.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ArthurZucker ArthurZucker merged commit f7069c4 into main Jan 30, 2026
24 of 26 checks passed
@ArthurZucker ArthurZucker deleted the fix-cb-serve branch January 30, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants