Skip to content

Fix FP8Expert for DeepSeek R1#43616

Merged
vasqu merged 7 commits intohuggingface:mainfrom
yiliu30:fix-fp8-expert-ds
Feb 2, 2026
Merged

Fix FP8Expert for DeepSeek R1#43616
vasqu merged 7 commits intohuggingface:mainfrom
yiliu30:fix-fp8-expert-ds

Conversation

@yiliu30
Copy link
Contributor

@yiliu30 yiliu30 commented Jan 30, 2026

Signed-off-by: yiliu30 yi4.liu@intel.com

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Signed-off-by: yiliu30 <yi4.liu@intel.com>
@yiliu30 yiliu30 changed the title use moe_intermediate_size for ds Fix FP8Expert for DeepSeek R1 Jan 30, 2026
@vasqu
Copy link
Contributor

vasqu commented Jan 30, 2026

cc @MekkCyber @SunMarc

Copy link
Contributor

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the nit from @MekkCyber and we cam merge

Copy link
Contributor

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@MekkCyber MekkCyber mentioned this pull request Feb 2, 2026
5 tasks
@yiliu30
Copy link
Contributor Author

yiliu30 commented Feb 2, 2026

Hi @SunMarc @MekkCyber look like the failed CI is unrelated to this PR, Could we proceed with the merge?

@vasqu
Copy link
Contributor

vasqu commented Feb 2, 2026

It was a flaky test, reran CI (for the failed tests) and it's green now so merging

@vasqu vasqu enabled auto-merge (squash) February 2, 2026 11:46
@vasqu vasqu merged commit 8fce0a1 into huggingface:main Feb 2, 2026
25 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants