Skip to content

fix norm_eps dtype#43669

Merged
Rocketknight1 merged 2 commits intohuggingface:mainfrom
fschlatt:main
Feb 3, 2026
Merged

fix norm_eps dtype#43669
Rocketknight1 merged 2 commits intohuggingface:mainfrom
fschlatt:main

Conversation

@fschlatt
Copy link
Contributor

@fschlatt fschlatt commented Feb 1, 2026

What does this PR do?

Fixes #43668

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, but you may need to make that change in the modular file as well and run make fix-repo to propagate it correctly.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

[For maintainers] Suggested jobs to run (before merge)

run-slow: modernbert

@fschlatt
Copy link
Contributor Author

fschlatt commented Feb 3, 2026

Thanks for the fix, but you may need to make that change in the modular file as well and run make fix-repo to propagate it correctly.

I updated the modular file and ran make fix-repo. Everything worked except for python utils/check_pipeline_typing.py --fix_and_overwrite and python utils/check_docstrings.py --fix_and_overwrite because of some torchvision error. I assume it's not a major issue.

@Rocketknight1 Rocketknight1 enabled auto-merge (squash) February 3, 2026 14:24
@Rocketknight1
Copy link
Member

Yeah, don't worry about that. Thank you for the PR!

@Rocketknight1 Rocketknight1 merged commit 01e860e into huggingface:main Feb 3, 2026
19 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModernBERTConfig norm_eps type hint is incorrect

3 participants