Skip to content

make sure hub errors are surfaced#43675

Merged
tarekziade merged 5 commits intohuggingface:mainfrom
tarekziade:tarekziade-fix-identifier-error
Feb 2, 2026
Merged

make sure hub errors are surfaced#43675
tarekziade merged 5 commits intohuggingface:mainfrom
tarekziade:tarekziade-fix-identifier-error

Conversation

@tarekziade
Copy link
Collaborator

@tarekziade tarekziade commented Feb 2, 2026

What does this PR do?

in PreTrainedTokenizerBase.from_pretrained this commit 73a13f8#diff-85b29486a884f445b1014%5B%E2%80%A6%5Df4ae701ee758a754fddcc1L1679 silenced hub errors, this is surfaced by

pytest -sv tests/models/auto/test_tokenization_auto.py::AutoTokenizerTest::test_tokenizer_identifier_non_existent

with

E           AssertionError: "julien-c/herlolip-not-exists is not a local folder and is not a valid model identifier" does not match "401 Client Error. (Request ID: Root=1-69806dfe-29b61b47408bd03420a3cdac;e2386594-f169-4d1b-9171-050ec211b4c8)

This patch removes the try/except block

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@tarekziade tarekziade self-assigned this Feb 2, 2026
@tarekziade tarekziade added the bug label Feb 2, 2026
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to fix the failing tests (maybe just marking them as flaky) to merge with a green CI?

@tarekziade tarekziade force-pushed the tarekziade-fix-identifier-error branch 2 times, most recently from 336dd98 to 0e20346 Compare February 2, 2026 11:18
@tarekziade tarekziade force-pushed the tarekziade-fix-identifier-error branch from 0e20346 to 9ff1d82 Compare February 2, 2026 12:24
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto

@tarekziade tarekziade merged commit 5ccea23 into huggingface:main Feb 2, 2026
25 checks passed
@tarekziade tarekziade deleted the tarekziade-fix-identifier-error branch February 2, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants