make sure hub errors are surfaced#43675
Merged
tarekziade merged 5 commits intohuggingface:mainfrom Feb 2, 2026
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Feb 2, 2026
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Do you want to fix the failing tests (maybe just marking them as flaky) to merge with a green CI?
336dd98 to
0e20346
Compare
0e20346 to
9ff1d82
Compare
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
in
PreTrainedTokenizerBase.from_pretrainedthis commit 73a13f8#diff-85b29486a884f445b1014%5B%E2%80%A6%5Df4ae701ee758a754fddcc1L1679 silenced hub errors, this is surfaced bywith
This patch removes the try/except block