Fix crash of custom models in Notebook or Repl#43690
Merged
Cyrilvallez merged 3 commits intomainfrom Feb 3, 2026
Merged
Conversation
Closed
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
approved these changes
Feb 2, 2026
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
Should we add a small warning? It might be confusing for users when they use set_xx then
Member
Author
|
Due to current implem, the warning would be shown all the time, even when the model is not even a MoE, so I think it would be even more confusing tbh... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #43645. It's quite unusual, but no reason it should crash in general