Remove SDPA workarounds for torch 2.4+#43754
Merged
vasqu merged 2 commits intohuggingface:mainfrom Feb 5, 2026
Merged
Conversation
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: diffllama, falcon, kyutai_speech_to_text, mimi, moshi, nemotron |
vasqu
approved these changes
Feb 5, 2026
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
Should have been removed earlier when we moved to 2.2.; good catch
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
tarekziade
pushed a commit
that referenced
this pull request
Feb 5, 2026
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
tarekziade
pushed a commit
that referenced
this pull request
Feb 5, 2026
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pytorch/pytorch#112577 was fixed in torch 2.2. Let's remove the workarounds and see what happen in the tests.