Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
reviewed
Feb 6, 2026
docker/torch-light.dockerfile
Outdated
| ENV UV_PYTHON=/usr/local/bin/python | ||
| RUN pip --no-cache-dir install uv && uv pip install --no-cache-dir -U pip setuptools | ||
| RUN uv pip install --no-cache-dir 'torch==2.9.1' 'torchaudio' 'torchvision' 'torchcodec==0.9.1' --index-url https://download.pytorch.org/whl/cpu | ||
| RUN uv pip install --no-cache-dir 'torch' 'torchaudio' 'torchvision' 'torchcodec' --index-url https://download.pytorch.org/whl/cpu |
Contributor
There was a problem hiding this comment.
Please let's do "<", I don't want the next torchcodec incident in 2months
Collaborator
Author
There was a problem hiding this comment.
yeah, forgot your previous message on slack , will change, thx a lot
ydshieh
commented
Feb 6, 2026
docker/examples-torch.dockerfile
Outdated
| ENV UV_PYTHON=/usr/local/bin/python | ||
| RUN pip --no-cache-dir install uv && uv pip install --no-cache-dir -U pip setuptools | ||
| RUN uv pip install --no-cache-dir 'torch==2.9.1' 'torchaudio' 'torchvision' 'torchcodec==0.9.1' --index-url https://download.pytorch.org/whl/cpu | ||
| RUN uv pip install --no-cache-dir 'torch<=2.10.0' 'torchaudio' 'torchvision' 'torchcodec<=0.9.1' --index-url https://download.pytorch.org/whl/cpu |
Collaborator
Author
There was a problem hiding this comment.
@vasqu I prefer to use <= here, more clear to me what is going on.
OK for you?
Contributor
There was a problem hiding this comment.
Don't forget to bump the torchcodec version as well
Collaborator
Author
There was a problem hiding this comment.
sorry, should be 0.10.0
jiosephlee
pushed a commit
to jiosephlee/transformers_latest
that referenced
this pull request
Feb 11, 2026
* well * unpin torch - build dev --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
So CircleCI will run with torch 2.10
CI is ✅ see here