Fix video interpolation in pe_audio_video#43811
Open
Rocketknight1 wants to merge 2 commits intomainfrom
Open
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: pe_audio_video |
Member
Author
|
run-slow: pe_audio_video |
Contributor
|
This comment contains models: ["models/pe_audio_video"] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
nice finding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
tests/models/pe_audio_video/test_modeling_pe_audio_video.py::PeAudioVideoEncoderTest::test_model_forward_default_config_valuesis flaky in the CI. In local testing, it failed in 5 out of 100 runs for me. After some digging, I figured out that in the failing runs, it takes a fast path when all the audio and video samples are the same length. However, this fast path is incorrect, because it interpolates alongseq_diminstead of thetimestepdimension, so we get an output with the wrong shape and the test fails.The fix is just to correct the fast path to interpolate the right dimension! cc @zucchini-nlp @tarekziade
Example failing run: https://app.circleci.com/pipelines/github/huggingface/transformers/163294/workflows/b07f04c5-f240-4601-aace-47f970ed7c1c/jobs/2151900