Remove unused dependencies#43904
Conversation
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
|
Are you sure about the |
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Sure, not used. At least they are not direct dependencies. |
|
Seems okay in that case, cc core maintainers @ArthurZucker @Cyrilvallez @vasqu since we're touching core dependencies! |
Cyrilvallez
left a comment
Cyrilvallez
left a comment
There was a problem hiding this comment.
It's alright for me to remove importlib_metadata as it's indeed superseded by built-in for all Python versions we support, and diffusers should not really be a dep. But why did you change the versions of other packages?
setup.py
Outdated
| "tqdm>=4.60", | ||
| "typer-slim>=0.9.0", |
There was a problem hiding this comment.
Why are we changing versions here?
There was a problem hiding this comment.
The code base uses features starting from minimum versions of these dependencies.
3 participants
What does this PR do?
removes two unused dependencies.