Migrate RegNet to standardized output tracing#43997
Open
karthiksuki wants to merge 2 commits intohuggingface:mainfrom
Open
Migrate RegNet to standardized output tracing#43997karthiksuki wants to merge 2 commits intohuggingface:mainfrom
karthiksuki wants to merge 2 commits intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: regnet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR migrates the RegNet model to the standardized output collection interface as part of the ongoing refactoring effort in issue #43979.
Specifically:
_can_record_outputsdictionary toRegNetPreTrainedModel.@capture_outputsdecorator to the baseRegNetModelforward pass.@can_return_tupledecorator to theRegNetForImageClassificationforward pass.output_attentions,output_hidden_states, andreturn_dictlogic, delegating this to the decorators.Ref #43979
Who can review?
@molbap (Reviewer - tracking issue #43979)
@yonigozlan (Vision models)