refactor output tracing in mamba#44003
Open
omkar-334 wants to merge 3 commits intohuggingface:mainfrom
Open
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: falcon_mamba, mamba |
Contributor
Author
|
@molbap - here I think falconmamba is copied from make fix-repo. What is the general convention - do we include the overwritten falconmamba over here itself, or do we merge without it and then focus on falconmamba in its own pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
mambamodel as per #43979cc @molbap
Note - Only 46 tests were passing initially, the rest were failing due to
TypeError: 'int' object is not iterable in SpecifierSet. I examined this and found out this is because of the library -"kernels>=0.10.2,<0.11". When i upgraded this library, all tests pass. The latest version is -Should we update
setup.py?