Skip to content

Remove other_workflow_run_ids for issue_comment in utils/notification_service.py#44036

Merged
ydshieh merged 1 commit intomainfrom
fix_logic
Feb 16, 2026
Merged

Remove other_workflow_run_ids for issue_comment in utils/notification_service.py#44036
ydshieh merged 1 commit intomainfrom
fix_logic

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Feb 16, 2026

What does this PR do?

So the following logic added in a previous PR #44033 could take effect

            # `include_all` is `True` when the CI is running on a pull request, so it treats all failing tests
            # in the current CI run as "new failing tests". The `utils/check_bad_commit.py`, run in a later job,
            # will analyze the scenario in depth, in particular if a failing test in the current run is a new
            # failing test, or already failed before but with the same/different failing reason.
            include_all = os.environ.get("GITHUB_EVENT_NAME") in ["issue_comment", "pull_request"]
            if include_all and prev_ci_artifacts is None:
                prev_ci_artifacts = {}

@ydshieh ydshieh merged commit d4bea33 into main Feb 16, 2026
16 checks passed
@ydshieh ydshieh deleted the fix_logic branch February 16, 2026 10:21
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants