Fix percentage formatting in help messages for gradient checkpointing, Liger Kernel, and empty cache steps#44100
Merged
qgallouedec merged 1 commit intomainfrom Feb 17, 2026
Merged
Conversation
…, Liger Kernel, and empty cache steps
Member
Author
|
ah right sorry for the duplicate |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
5 tasks
Member
|
Thanks, glad to see this has been already fixed! For future reference, in most OSS workflows the usual practice is to keep the earlier PR open and mark the later one as a duplicate before closing it. That helps preserve the original discussion context and avoids losing review history on the first contribution. Not a big deal at all, just mentioning it for consistency going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In huggingface/trl#5112 a user reported that
trl sft --helpfailsIt's because three inherited args from
TrainingArguments(torch_empty_cache_steps,gradient_checkpointinganduse_liger_kernel)help strings include bare%which break argparse formatting on Python 3.13. This PR fixes it.