Skip to content

fix: don't move model to device under other dist train backends#44189

Open
excepshenal wants to merge 1 commit intohuggingface:mainfrom
excepshenal:excepshenal-fix-mp-full-eval-move-model-to-device
Open

fix: don't move model to device under other dist train backends#44189
excepshenal wants to merge 1 commit intohuggingface:mainfrom
excepshenal:excepshenal-fix-mp-full-eval-move-model-to-device

Conversation

@excepshenal
Copy link
Copy Markdown

What does this PR do?

Under fp16_full_eval or bf16_full_eval, still don't move model to device if using another dist train backend.

This is causing bugs with FSDP2 + bf16_full_eval. The dist train backend would still be in charge of moving model to device.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@SunMarc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant