Speed create_import_structure up with os.scandir()#44253
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
cc @LysandreJik while you're working on this! I don't think it addresses the contributor's issue but it might be some free speedup regardless. The tl;dr is that the existing code does two wasteful things. Firstly, it doesn't skip Secondly, the old approach of |
e1a72ac to
e966399
Compare
|
(Failing test is unrelated and goes on my list of flaky tests to fix) |
LysandreJik
left a comment
There was a problem hiding this comment.
Thank you @Rocketknight1 !
create_import_structure_from_pathdoes some redundantoscalls, so I'm experimenting with changes to see if we can speed up loading a lot.Related to #44246