Fix and optimize ANSI color handling in loading report for interactive terminals#44341
Closed
Kokonico wants to merge 1 commit into
Closed
Fix and optimize ANSI color handling in loading report for interactive terminals#44341Kokonico wants to merge 1 commit into
Kokonico wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure ANSI formatting codes in the state-dict loading report are only emitted when running in an interactive terminal, avoiding escape sequences in redirected/logged output.
Changes:
- Added a
_palette()helper to gate raw ANSI palette codes onsys.stdout.isatty(). - Updated several in-report uses of
PALETTE['italic']to_palette('italic')so formatting is skipped in non-interactive contexts.
redpanda1995
approved these changes
Mar 1, 2026
Kokonico
changed the title
Kokonico
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44336
Changes
_palettefunction to return the ANSI code for a given color or format only ifsys.stdoutis interactive. (src/transformers/utils/loading_report.py)PALETTE[<format>]in the loading report to use_palette(<format>), ensuring formatting is only applied in interactive terminals. (src/transformers/utils/loading_report.py)_colorfunction to a singular line.Who can help
@Cyrilvallez