Skip to content

[Trainer] fix SP loss#44461

Merged
SunMarc merged 5 commits intohuggingface:mainfrom
kashif:sp_deepspeed_loss
Mar 5, 2026
Merged

[Trainer] fix SP loss#44461
SunMarc merged 5 commits intohuggingface:mainfrom
kashif:sp_deepspeed_loss

Conversation

@kashif
Copy link
Contributor

@kashif kashif commented Mar 5, 2026

What does this PR do?

for SP loss we do not have torch device mesh but rather a deepspeed only.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@kashif kashif requested a review from SunMarc March 5, 2026 11:39
@SunMarc
Copy link
Member

SunMarc commented Mar 5, 2026

yes sorry, my previous pr reverted this change by mistake

@SunMarc
Copy link
Member

SunMarc commented Mar 5, 2026

it will be fixed here but we can merge this do unblock you : #44338

@kashif
Copy link
Contributor Author

kashif commented Mar 5, 2026

ok i have added your changes here

@kashif
Copy link
Contributor Author

kashif commented Mar 5, 2026

@SunMarc sorry for the confusion, shall i close this?

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again

@SunMarc
Copy link
Member

SunMarc commented Mar 5, 2026

We can merge this !

@SunMarc SunMarc merged commit 81b5343 into huggingface:main Mar 5, 2026
26 checks passed
@kashif
Copy link
Contributor Author

kashif commented Mar 5, 2026

thank you @SunMarc

@kashif kashif deleted the sp_deepspeed_loss branch March 5, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants