[remote code/vllm] Fix incorrect tied weights#44469
Merged
Cyrilvallez merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
vasqu
approved these changes
Mar 5, 2026
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
Fair enough, thanks for fixing
NielsRogge
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For remote code that behave correctly with tied weights, we need to keep the same behavior as for the main lib, i.e. not remove them from tied weights (as tied weights are marked as missing to avoid inits!!)