Skip to content

Follow-up typing checking fixes#44500

Merged
tarekziade merged 6 commits intomainfrom
tarekziade-remove-jax
Mar 9, 2026
Merged

Follow-up typing checking fixes#44500
tarekziade merged 6 commits intomainfrom
tarekziade-remove-jax

Conversation

@tarekziade
Copy link
Collaborator

@tarekziade tarekziade commented Mar 6, 2026

What does this PR do?

  • Do proper type check in case jax is installed.
  • Make sure older torch versions don't raise typing issues

@tarekziade tarekziade requested a review from zucchini-nlp March 6, 2026 16:56
@tarekziade tarekziade self-assigned this Mar 6, 2026
@tarekziade tarekziade changed the title Remove jax from import_utils Proper type fixing for jax in import_utils Mar 6, 2026
@tarekziade tarekziade changed the title Proper type fixing for jax in import_utils Follow-up typing checking fixes Mar 7, 2026
@tarekziade tarekziade force-pushed the tarekziade-remove-jax branch from c527321 to 71a7822 Compare March 7, 2026 12:41
Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harms a bit readability imo, but fine if ty cannot do without 🥲

@tarekziade tarekziade merged commit 976d8cc into main Mar 9, 2026
28 checks passed
@tarekziade tarekziade deleted the tarekziade-remove-jax branch March 9, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants