Fix KeyError in _parse_type_hint when Union contains Any#44525
Merged
Rocketknight1 merged 2 commits intohuggingface:mainfrom Mar 9, 2026
Merged
Conversation
In _parse_type_hint, when processing Union types, the code
accesses subtype["type"] without checking the key exists.
Union types containing `Any` crash because _get_json_schema_type(Any)
returns {} with no "type" key, causing a KeyError.
Add a guard to check "type" key existence before accessing it.
Signed-off-by: JiangNan <1394485448@qq.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
KeyErrorcrash in_parse_type_hintinchat_template_utils.py(line 117).When processing Union types, the code accesses
subtype["type"]without checking the key exists._get_json_schema_type(Any)returns{}(empty dict with no "type" key), so Union types containingAny(e.g.,Union[str, Any]) crash with aKeyError.This guard ensures the code falls through to the
anyOfbranch for types that don't have a simple "type" key.Test plan
_get_json_schema_type(Any)returns{}with no "type" keyanyOfbranch