optionally override tokenizer class with serialized tokenizer #44606
Open
optionally override tokenizer class with serialized tokenizer #44606
Conversation
…le, when they don't match
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
This is a hard one... I'm really against it. IMO we need to find all model type that have an issue, but when there is no config.json but there is a tokenizer.json we can set class to TokenizersBackend ?
IMO we need to just isolate all model classes that are wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v5, we enforce creating a model-specific tokenizer (ex. LlamaTokenizer, Qwen2Tokenizer, et .) object when specified.
tokenizer_classis set intokenization_config.jsontokenizer_classbased on themodel_typeinconfig.json.In v4, we always loaded the tokenizer object from
tokenizer.jsonortokenizer.modelor other file directly without caring what the configs said.This unveiled a lot of stale and incorrect tokenizer classes on the hub. For v5, we could introduce a way to (as in v4) optionally just dump whatever is in the
_tokenizerobject exactly as the tokenizer file has it.We introduced
MODELS_WITH_INCORRECT_HUB_TOKENIZER_CLASSto forceTokenizersBackend, but for some checkpoints that don't have aconfig.jsonto create a mapping for, (ex: https://huggingface.co/jashing/tinyllama-colorist-lora/blob/main/tokenizer_config.json), we need another option to overrideIn this PR: do a light check if the _tokenizer object's are the same types, type(normalizer) == type(normalizer) , etc. If not and if we allow override, we do.