Allow to disable stdout hiding for TP#44608
Merged
michaelbenayoun merged 4 commits intohuggingface:mainfrom Mar 12, 2026
Merged
Allow to disable stdout hiding for TP#44608michaelbenayoun merged 4 commits intohuggingface:mainfrom
michaelbenayoun merged 4 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
3outeille
reviewed
Mar 11, 2026
| device_map = tp_device | ||
| # Silence output for non-primary ranks | ||
| if index > 0: | ||
| if index > 0 and os.environ.get("HF_TP_SILENCE_NON_PRIMARY_RANK_OUTPUT", "1") == "1": |
Member
There was a problem hiding this comment.
I think it would be better to enable stdout on all ranks by default and filter through torchrun using --local-ranks-filter <local rank>. What do you think ?
Member
Author
There was a problem hiding this comment.
Yes we could do that. Because the current behavior is kind of unexpected.
Member
Author
|
Done |
michaelbenayoun
force-pushed
the
tp_hide_stdout_option
branch
from
f2a07f9 to
29c370c
Compare
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto, clap, gpt_neox_japanese, jamba, lasr, lfm2, lfm2_moe, olmo3, paddleocr_vl, qwen2_5_vl, qwen2_vl, sam_hq, vibevoice_acoustic_tokenizer, vibevoice_asr |
3outeille
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
By default,
initialize_tensor_parallelismhides stdout and stderr for ranks > 0. While convenient, this is not perfect for dev and debugging. I suggest we simply add a flag to be able to disable this feature if wanted.