Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
reviewed
Mar 16, 2026
Member
Cyrilvallez
left a comment
There was a problem hiding this comment.
I think we should add a checl for emptyness!
Comment on lines
+4407
to
+4408
| # Check if model has a TP plan | ||
| if self._tp_plan: |
Member
There was a problem hiding this comment.
Shiuldn't we check if it's empty?
Member
Author
There was a problem hiding this comment.
I was checking for truthiness because the default value is None if post_init is not called
Comment on lines
+4428
to
+4429
| # Check if model has a PP plan | ||
| if self._pp_plan: |
Member
There was a problem hiding this comment.
Same here, let's check if it's empty
Cyrilvallez
approved these changes
Mar 16, 2026
Member
Cyrilvallez
left a comment
There was a problem hiding this comment.
Alright, we can use the implicit bool value of the dict
Member
|
@bot /style |
Contributor
|
Style fix bot fixed some files and pushed the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In configs,
base_model_pp_planandbase_model_tp_plandefault toNoneIn models,
_pp_planand_tp_planlook like they default toNonebased on the class variables, but will actually always be a dict because ofpost_init.This means that
supports_pp_planandsupports_tp_planalways returnTrue.This PR:
supportsmethodspp_plan's setter (same astp_plan's)PreTrainedModel._pp_planbecause it's always atuple[str, str]not anEnum