fix: Cache XLNet relative_positional_encoding to avoid CPU computation#44762
Closed
BillionClaw wants to merge 1 commit intohuggingface:mainfrom
Closed
Conversation
…al_encoding The relative_positional_encoding method was creating tensors on CPU every forward pass because torch.arange was not using the device parameter. This caused unnecessary CPU-GPU transfers when running on CUDA. Fixes huggingface#44737
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: xlnet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XLNet.relative_positional_encoding creates intermediate tensors on CPU every forward pass because torch.arange was missing the device parameter. This causes unnecessary CPU-GPU transfers when running on CUDA.
Added device=self.device to all 4 torch.arange calls in the method.
Fixes #44737