fix: handle dict vocab in CamembertTokenizer for tokenizer.json (#44488)#44800
Closed
aayushbaluni wants to merge 2 commits intohuggingface:mainfrom
Closed
fix: handle dict vocab in CamembertTokenizer for tokenizer.json (#44488)#44800aayushbaluni wants to merge 2 commits intohuggingface:mainfrom
aayushbaluni wants to merge 2 commits intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: camembert |
Member
|
No drive-by code agent PRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #44488
CamembertTokenizerraisedValueError: too many values to unpack (expected 2)when loading models likecjvt/sleng-bertthat provide vocab as a dict{token: id}fromtokenizer.json(BPE format). The tokenizer expected a list of(token, score)tuples for Unigram.Root cause
When
AutoTokenizer.from_pretrainedloads a model withtokenizer.json,convert_to_native_formatpasses vocab as a dict.CamembertTokenizerassumed list format and unpacked(tok, _) = token_string, causing the error.Fix
Handle dict vocab by converting to list of
(token, 0.0)tuples in id order before passing to Unigram.Testing
test_camembert_tokenizer_with_dict_vocabintest_tokenization_camembert.pyCamembertTokenizer(vocab=dict_from_sleng_bert)loads successfullyMade with Cursor