Skip to content

Dequant fix#44815

Draft
ArthurZucker wants to merge 14 commits intomainfrom
dequant-fix
Draft

Dequant fix#44815
ArthurZucker wants to merge 14 commits intomainfrom
dequant-fix

Conversation

@ArthurZucker
Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Copy Markdown
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to not forget

full_layer_name=layer_name,
model=model,
config=config,
missing_keys=loading_info.missing_keys if loading_info else None,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up, please don't remove missing keys

Comment on lines +758 to +767
if f"{full_layer_name[:-7]}_scale_inv" in kwargs["loading_info"].unexpected_keys:
kwargs["loading_info"].unexpected_keys.remove(f"{full_layer_name[:-7]}_scale_inv")
kwargs["loading_info"].unexpected_keys.remove(f"{full_layer_name[:-7]}_weight")
else:
quantized, scales = input_dict.values()
quantized, scales =quantized[0], scales[0]
if f"{full_layer_name}_scale_inv" in kwargs["loading_info"].unexpected_keys:
kwargs["loading_info"].unexpected_keys.remove(f"{full_layer_name}_scale_inv")
kwargs["loading_info"].unexpected_keys.remove(f"{full_layer_name}_activation_scale")
kwargs["loading_info"].unexpected_keys.remove(f"{full_layer_name}_weight")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really needed ?

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: mistral4, finegrained_fp8

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants