Fix loading issue in Sam3#44831
Merged
zucchini-nlp merged 1 commit intohuggingface:mainfrom Mar 18, 2026
Merged
Conversation
Member
Author
|
run-slow: sam3, sam3_video, sam3_tracker_video |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: sam3_tracker_video |
Contributor
|
This comment contains models: ["models/sam3", "models/sam3_tracker_video", "models/sam3_video"] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
approved these changes
Mar 18, 2026
Collaborator
ydshieh
left a comment
There was a problem hiding this comment.
I know you are busy, but a 1 - 3 sentences to explain what was wrong and the fix etc would be nice.
Always have a bit of context - make the history more accessbible.
Thank you for the fix!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix loading in Sam3 which currently doesn't match the state dict keys from checkpoint. Adding a correct base model prefix will add it to all state dict keys, making the ckpt load-able
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.