fix: move comments before @torch.jit.script decorator for Python 3.13 compatibility#44856
Closed
hkc5 wants to merge 1 commit intohuggingface:mainfrom
Closed
fix: move comments before @torch.jit.script decorator for Python 3.13 compatibility#44856hkc5 wants to merge 1 commit intohuggingface:mainfrom
hkc5 wants to merge 1 commit intohuggingface:mainfrom
Conversation
… compatibility Python 3.13's stricter parser fails when there's a comment between the @torch.jit.script decorator and the function definition. This fix moves the comments before the decorator for the three affected functions in the DebertaV2 model. Fixes huggingface#44855
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: deberta_v2 |
Member
|
No drive-by code agent PRs on other people's issues! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Python 3.13's stricter parser fails when there's a comment between the
@torch.jit.scriptdecorator and the function definition, causing an IndentationError when importing DebertaV2Model.Changes
@torch.jit.scriptdecorator for three functions in modeling_deberta_v2.py:c2p_dynamic_expandp2c_dynamic_expandpos_dynamic_expandTesting
Fixes #44855