fix: prevent IndexError in Whisper word timestamp decode#44885
Closed
guoyangzhen wants to merge 1 commit intohuggingface:mainfrom
Closed
fix: prevent IndexError in Whisper word timestamp decode#44885guoyangzhen wants to merge 1 commit intohuggingface:mainfrom
guoyangzhen wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: whisper |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=44885&sha=a326a1 |
Member
|
Your bot has created a duplicate PR at #44902 for the same issue. As we mentioned in CONTRIBUTING, we're being flooded with code agent PRs right now, so temporarily blocking you to cut down the notification spam |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In _split_tokens_on_unicode(), when the decoded token stream ends with a dangling Unicode replacement character (U+FFFD), the computed index can equal len(decoded_full), causing IndexError: string index out of range.
The failing line:
When unicode_offset + decoded.index(replacement_char) >= len(decoded_full), this crashes.
Fix
Add bounds check before indexing into decoded_full:
This ensures we only access decoded_full when the index is valid.