Fix: Update optimization.py#44909
Merged
Rocketknight1 merged 7 commits intohuggingface:mainfrom Mar 24, 2026
Merged
Conversation
Rocketknight1
force-pushed
the
fix-inverse-sqrt-scheduler-args
branch
from
dbbf55a to
2e7f6fa
Compare
The `get_scheduler` function was identifying the `inverse_sqrt` scheduler type but failing to pass `**scheduler_specific_kwargs` to the underlying `get_inverse_sqrt_schedule` function. This caused user-defined parameters like `timescale` to be silently ignored. This commit adds the missing kwargs to the function call at line 664. Fixes huggingface#44908
Rocketknight1
force-pushed
the
fix-inverse-sqrt-scheduler-args
branch
from
2e7f6fa to
0028eed
Compare
Rocketknight1
approved these changes
Mar 23, 2026
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Yeah, seems good to me!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
auto-merge was automatically disabled
March 23, 2026 17:32
Head branch was pushed to by a user without write access
Contributor
Author
|
@Rocketknight1 |
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Mar 27, 2026
* Update optimization.py The `get_scheduler` function was identifying the `inverse_sqrt` scheduler type but failing to pass `**scheduler_specific_kwargs` to the underlying `get_inverse_sqrt_schedule` function. This caused user-defined parameters like `timescale` to be silently ignored. This commit adds the missing kwargs to the function call at line 664. Fixes huggingface#44908 * Update optimization.py * Update optimization.py * Update optimization.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get_schedulerfunction was identifying theinverse_sqrtscheduler type but failing to pass**scheduler_specific_kwargsto the underlyingget_inverse_sqrt_schedulefunction.This caused user-defined parameters like
timescaleto be silently ignored. This commit adds the missing kwargs to the function call at line 664.Fixes #44908