fix(gpt-neox): preserve rotary_pct across save/load cycle#44917
Closed
s-zx wants to merge 1 commit intohuggingface:mainfrom
Closed
fix(gpt-neox): preserve rotary_pct across save/load cycle#44917s-zx wants to merge 1 commit intohuggingface:mainfrom
s-zx wants to merge 1 commit intohuggingface:mainfrom
Conversation
`convert_rope_params_to_dict` unconditionally wrote the default value
0.25 to `partial_rotary_factor` whenever `rotary_pct` was absent from
kwargs, which happens on every `from_pretrained` call (the key is
serialised inside `rope_parameters`, not as a top-level key).
Use `kwargs.pop("rotary_pct", None)` and guard with `setdefault` so
the existing value inside `rope_parameters` is preserved when
`rotary_pct` is not present in the incoming kwargs.
Fixes huggingface#44913
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gpt_neox |
Member
|
Hi @s-zx, no more code agent PRs like this please! As we state in CONTRIBUTING, the reviewers are getting flooded with these, and usually they have issues that require extra maintainer attention. For example, your other PR at #44916 broke the copying mechanism, which was being discussed in the issue at #44855 when you opened the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GPTNeoXConfig.convert_rope_params_to_dictunconditionally overwroterope_parameters["partial_rotary_factor"]with the default0.25whenrotary_pctwas absent from kwargs.On every
from_pretrainedcall,rotary_pctis not present as a top-levelkey in
config.json(it is stored insiderope_parameters), so the value wassilently reset to
0.25.Fix
Replace the unconditional assignment with a conditional +
setdefault:When
rotary_pctis absent (the reload path),setdefaultonly fills in0.25if
partial_rotary_factoris not already present, so an existing value is preserved.Fixes #44913