Skip to content

Fix failing SmolLM3IntegrationTest#45048

Merged
Rocketknight1 merged 1 commit intohuggingface:mainfrom
Sai-Suraj-27:smollm3_fix
Mar 27, 2026
Merged

Fix failing SmolLM3IntegrationTest#45048
Rocketknight1 merged 1 commit intohuggingface:mainfrom
Sai-Suraj-27:smollm3_fix

Conversation

@Sai-Suraj-27
Copy link
Copy Markdown
Contributor

@Sai-Suraj-27 Sai-Suraj-27 commented Mar 27, 2026

What does this PR do?

Fixes failing SmolLM3IntegrationTest:test_model_3b_long_prompt. SmolLM3 has do_sample=True by default

image

Code Agent Policy

The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.

PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.

This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read CONTRIBUTING.md.

  • I confirm that this is not a pure code agent PR.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Rocketknight1 @vasqu

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: smollm3

@Rocketknight1
Copy link
Copy Markdown
Member

run-slow: smollm3

@github-actions
Copy link
Copy Markdown
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/smollm3"]
quantizations: []

@Sai-Suraj-27
Copy link
Copy Markdown
Contributor Author

run-slow: smollm3

Thanks for the review @Rocketknight1. This one should also be triggered 👀.

@github-actions
Copy link
Copy Markdown
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 7cfd69df workflow commit (merge commit)
PR 51487128 branch commit (from PR)
main 23773e71 base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

Copy link
Copy Markdown
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM, and I think the do_sample fix is obviously correct!

@Rocketknight1 Rocketknight1 enabled auto-merge March 27, 2026 13:54
@Rocketknight1 Rocketknight1 added this pull request to the merge queue Mar 27, 2026
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Merged via the queue into huggingface:main with commit cc4ef19 Mar 27, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants