Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Mar 30, 2026
| ) | ||
| if warmup: | ||
| # Warmup is long (~30 sec): best to signal the user it's happening than let them think the manager is stuck | ||
| print("Warming up for coninuous batching...") |
Collaborator
Author
There was a problem hiding this comment.
With what severity? Warning? Info wont show up on normal user terminal :/
Collaborator
There was a problem hiding this comment.
Yeah warninng sounds good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a warmup phase before generation starts, turned on by default.
It allows for better diagnostics and a more representative user experience than without warmup, where the cost of wamup is payed during the first request rather than in a phase before generation starts.
Warmup is skipped if cuda graphs and compile are both turned off.