fix(testing_utils): guard get_device_capability with torch.cuda.is_available()#45472
Closed
kevinmalana wants to merge 1 commit intohuggingface:mainfrom
Closed
fix(testing_utils): guard get_device_capability with torch.cuda.is_available()#45472kevinmalana wants to merge 1 commit intohuggingface:mainfrom
kevinmalana wants to merge 1 commit intohuggingface:mainfrom
Conversation
…ailable() Fixes crash in get_device_properties() when CUDA is installed but no GPU is present (e.g., CPU-only cloud studio with CUDA libraries). The function checked IS_CUDA_SYSTEM (torch.version.cuda is not None) but then called torch.cuda.get_device_capability() without verifying an actual GPU exists. Fixes huggingface#45341
Member
|
Please check that there aren't 4 other identical duplicate code agent PRs before you open number 5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a crash in
get_device_properties()intesting_utils.pywhen CUDA is installed on the system but no GPU device is present (e.g., a CPU-only cloud studio with CUDA libraries installed).The function called
torch.cuda.get_device_capability()immediately after checkingIS_CUDA_SYSTEM(which isTruewhenevertorch.version.cuda is not None), without first verifying that an actual GPU is available. On CUDA-installed but GPU-less systems,get_device_capability()raises an error.Fixes #45341
Changes
src/transformers/testing_utils.py: Addif not torch.cuda.is_available(): return (torch_device, None, None)guard inside theIS_CUDA_SYSTEM or IS_ROCM_SYSTEMbranch ofget_device_properties(), before theget_device_capability()call.Tests
This is a fix to the test infrastructure itself (
testing_utils.py). The change prevents a crash that occurs in environments whereIS_CUDA_SYSTEM=Truebut no physical GPU is present.Notes