Fix get_device_properties crash when CUDA is installed but no GPU#45509
Open
Jah-yee wants to merge 1 commit intohuggingface:mainfrom
Open
Fix get_device_properties crash when CUDA is installed but no GPU#45509Jah-yee wants to merge 1 commit intohuggingface:mainfrom
Jah-yee wants to merge 1 commit intohuggingface:mainfrom
Conversation
…available When torch.cuda.is_available() returns False (e.g., headless cloud instance with CUDA toolkit installed but no GPU), torch.cuda.get_device_capability() would raise a RuntimeError. Added a guard check before accessing CUDA. Fixes huggingface#45341
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45509&sha=92806c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
Problem
In
src/transformers/testing_utils.py, theget_device_properties()function checksIS_CUDA_SYSTEMto determine whether to calltorch.cuda.get_device_capability(). However,IS_CUDA_SYSTEMis set toTruewhentorch.version.cudais notNone, regardless of whether a GPU is actually available.When CUDA is installed (e.g., CUDA toolkit on a headless cloud instance with no GPU), but no GPU device is present,
torch.cuda.get_device_capability()raises aRuntimeError, causing the function to crash.Solution
Added a guard check for
torch.cuda.is_available()before callingtorch.cuda.get_device_capability():When CUDA is installed but no GPU is available, the function will now fall through to the
elsebranch and return(torch_device, None, None)instead of crashing.Testing
get_device_properties()on a CUDA-installed but GPU-less environment (e.g., cloud CPU-only instance with CUDA toolkit).test_get_device_propertiesshould continue to pass on GPU-enabled machines.Fixes #45341
Thank you for your attention. If there are any issues or suggestions, please leave a comment and I will address them promptly.
Warmly,
RoomWithOutRoof