Fix CUDA availability check in get_device_properties()#45515
Open
Jah-yee wants to merge 1 commit intohuggingface:mainfrom
Open
Fix CUDA availability check in get_device_properties()#45515Jah-yee wants to merge 1 commit intohuggingface:mainfrom
Jah-yee wants to merge 1 commit intohuggingface:mainfrom
Conversation
Fixes a RuntimeError on systems where CUDA is installed but no GPU is available. The function now checks torch.cuda.is_available() before calling torch.cuda.get_device_capability(), preventing crashes when running on CPU-only machines with CUDA-capable drivers. Also removes redundant 'import torch' statement that was inside the conditional block.
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45515&sha=b5c6f9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
Summary
This PR fixes a bug in
src/transformers/testing_utils.pywhereget_device_properties()callstorch.cuda.get_device_capability()without first checking if a GPU is actually available.Bug Description
When CUDA is installed on a system (e.g.,
torch.version.cudais notNone) but no GPU is present, callingtorch.cuda.get_device_capability()raises aRuntimeError.Fix
Changed the condition from:
to:
This ensures the GPU capability call only happens when a GPU is actually present, and also removes the redundant
import torchstatement that was inside the conditional block (the import is already at the top of the file).Reference
Fixes #45341
Thank you for your attention. If there are any issues or suggestions, please leave a comment and I will address them promptly.
Warmly,
RoomWithOutRoof