T5Gemma2: fix prepare_decoder_input_ids_from_labels#45516
Open
Tokarak wants to merge 1 commit intohuggingface:mainfrom
Open
T5Gemma2: fix prepare_decoder_input_ids_from_labels#45516Tokarak wants to merge 1 commit intohuggingface:mainfrom
prepare_decoder_input_ids_from_labels#45516Tokarak wants to merge 1 commit intohuggingface:mainfrom
Conversation
Rename arg from `input_ids` to `labels`, to be consistent with other models' `prepare_decoder_input_ids_from_labels` Fix broken interaction when DataCollatorForSeq2Seq passes argument as a hard-coded "labels" kwarg
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: t5gemma2 |
Author
|
I just verified that this patch applied to my local transformers install does in fact fix the bug with DataCollatorForSeq2Seq |
4 tasks
Author
|
The issue mentioned above contains a script that can reproduce the bug this PR is fixing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename arg from
input_idstolabels(using IDE rename), to beconsistent with other models'
prepare_decoder_input_ids_from_labels.Fix broken interaction when DataCollatorForSeq2Seq passes argument
as a hard-coded "labels" kwarg.
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Tagging @Cyrilvallez.