Fix local_files_only tokenizer fallback when tokenizer files are missing (Issue 45538)#45541
Open
Brianzhengca wants to merge 1 commit intohuggingface:mainfrom
Open
Fix local_files_only tokenizer fallback when tokenizer files are missing (Issue 45538)#45541Brianzhengca wants to merge 1 commit intohuggingface:mainfrom
Brianzhengca wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45541&sha=249d2e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #45538
Root Cause
from_pretrained(..., local_files_only=True)let missing tokenizer files resolve to None and still proceeded into _from_pretrained(...). That allowed a stub tokenizer to initialize instead of raising, which led to the bogus hugemodel_max_length.Describe the Fix
The fix adds a fail-closed check in
PreTrainedTokenizerBase.from_pretrained.After resolving files, it now checks whether all real tokenizer assets for that class resolved to None.
If they did, it raises the existing
Can't load tokenizer... OSErrorinstead of continuing into_from_pretrained(...)and constructing a stub tokenizerLocal Tests
BertTokenizerandCLIPTokenizerusing a nonexistent model id andlocal_files_only=True.Before the fix, they loaded unexpectedly with the huge fallback max length.
After the fix, they raised the expected
OSError.Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case. (CLIPTokenizer uses 10**30 as
model_max_length#45538)documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker @Cyrilvallez