Skip to content

fix padding side issue for fast_vlm tests#45592

Merged
ydshieh merged 3 commits intohuggingface:mainfrom
kaixuanliu:fast-vlm-fix
Apr 28, 2026
Merged

fix padding side issue for fast_vlm tests#45592
ydshieh merged 3 commits intohuggingface:mainfrom
kaixuanliu:fast-vlm-fix

Conversation

@kaixuanliu
Copy link
Copy Markdown
Contributor

@kaixuanliu kaixuanliu commented Apr 23, 2026

This PR fixes failed test case: tests/models/fast_vlm/test_modeling_fast_vlm.py::FastVlmForConditionalGenerationIntegrationTest::test_small_model_integration_test_batch
@ydshieh pls help review, thx!

Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: fast_vlm

Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
@kaixuanliu kaixuanliu marked this pull request as ready for review April 23, 2026 02:51
@ydshieh
Copy link
Copy Markdown
Collaborator

ydshieh commented Apr 28, 2026

Run in CI runner, all ✅ (for single gpu runner) and indeed this PR also fixes the failing test on our Nvidia CI.

Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ydshieh ydshieh merged commit f4fc6d0 into huggingface:main Apr 28, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants