fix 2 failed test cases for blt model on XPU#45596
Open
kaixuanliu wants to merge 7 commits intohuggingface:mainfrom
Open
fix 2 failed test cases for blt model on XPU#45596kaixuanliu wants to merge 7 commits intohuggingface:mainfrom
kaixuanliu wants to merge 7 commits intohuggingface:mainfrom
Conversation
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
ydshieh
approved these changes
Apr 28, 2026
Collaborator
|
run-slow: blt |
Contributor
|
This comment contains models: ["models/blt"] |
Collaborator
|
I update some expected values. @kaixuanliu You might want to run again with XPU, and update with |
ydshieh
reviewed
Apr 28, 2026
| raise ValueError("input_ids is required for entropy-based patching") | ||
| _, patch_lengths, _ = self.patcher( | ||
| input_ids, | ||
| input_ids.to(self.patcher.embed_tokens.weight.device), |
Collaborator
There was a problem hiding this comment.
it's not clear why self.patcher doesn't handle the input device well.
Collaborator
There was a problem hiding this comment.
Likely the BltPatcher itself is BltPreTrainedModel
Collaborator
|
run-slow: blt |
Contributor
|
This comment contains models: ["models/blt"] |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: blt |
Collaborator
|
run-slow: blt |
Contributor
|
This comment contains models: ["models/blt"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ydshieh pls help review, thx!