Fix SDPA inference tolerances for MPS backend#45648
Closed
voodoovampire wants to merge 1 commit intohuggingface:mainfrom
Closed
Fix SDPA inference tolerances for MPS backend#45648voodoovampire wants to merge 1 commit intohuggingface:mainfrom
voodoovampire wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: video_llama_3 |
Member
|
Closing as per the comments in #45644 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45644
This PR adjusts
test_eager_matches_sdpa_inferenceon the MPS backend by routing"mps"through the same tolerance branch as"xpu"in:tests/test_modeling_common.pytests/models/video_llama_3/test_modeling_video_llama_3.pyThe previous default tolerances were too strict for fp16 on MPS and caused spurious test failures.