Skip to content

TST Run fast PEFT tests in normal CI#45679

Open
BenjaminBossan wants to merge 1 commit intohuggingface:mainfrom
BenjaminBossan:tst-run-fast-peft-tests-in-normal-ci
Open

TST Run fast PEFT tests in normal CI#45679
BenjaminBossan wants to merge 1 commit intohuggingface:mainfrom
BenjaminBossan:tst-run-fast-peft-tests-in-normal-ci

Conversation

@BenjaminBossan
Copy link
Copy Markdown
Member

What does this PR do?

PEFT tests were marked as slow, even though they're not slow. According to a comment there, this was probably only done to avoid running the tests before PEFT was released.

The @slow marker is now removed. All these tests use tiny models and on my machine, with warm HF cache, they passed in <12 sec on CPU without parallelism. It should thus be safe to assume that they are indeed fast enough. With these tests now running in normal CI, we should be able to prevent PEFT regressions in the future.

Note that the hotswapping tests are still marked as slow, as they partly require calling torch.compile.

Code Agent Policy

  • No bots were harmed while writing this PR.

Before submitting

PEFT tests were marked as slow, even though they're not slow. According
to a comment there, this was probably only done to avoid running the
tests before PEFT was released.

The @slow marker is now removed. All these tests use tiny models and on
my machine, with warm HF cache, they passed in <12 sec on CPU without
parallelism. It should thus be safe to assume that they are indeed fast
enough. With these tests now running in normal CI, we should be able to
prevent PEFT regressions in the future.

Note that the hotswapping tests are still marked as slow, as they partly
require calling torch.compile.
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@BenjaminBossan
Copy link
Copy Markdown
Member Author

@ydshieh It looks like all PEFT tests were skipped because PEFT is not installed. Should PEFT be added as a test dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants