TST Run fast PEFT tests in normal CI#45679
Open
BenjaminBossan wants to merge 1 commit intohuggingface:mainfrom
Open
TST Run fast PEFT tests in normal CI#45679BenjaminBossan wants to merge 1 commit intohuggingface:mainfrom
BenjaminBossan wants to merge 1 commit intohuggingface:mainfrom
Conversation
PEFT tests were marked as slow, even though they're not slow. According to a comment there, this was probably only done to avoid running the tests before PEFT was released. The @slow marker is now removed. All these tests use tiny models and on my machine, with warm HF cache, they passed in <12 sec on CPU without parallelism. It should thus be safe to assume that they are indeed fast enough. With these tests now running in normal CI, we should be able to prevent PEFT regressions in the future. Note that the hotswapping tests are still marked as slow, as they partly require calling torch.compile.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PEFT tests were marked as slow, even though they're not slow. According to a comment there, this was probably only done to avoid running the tests before PEFT was released.
The
@slowmarker is now removed. All these tests use tiny models and on my machine, with warm HF cache, they passed in <12 sec on CPU without parallelism. It should thus be safe to assume that they are indeed fast enough. With these tests now running in normal CI, we should be able to prevent PEFT regressions in the future.Note that the hotswapping tests are still marked as slow, as they partly require calling
torch.compile.Code Agent Policy
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.