Restore TokenizersBackend override for DeepSeek V3/R1 tokenizer dispatch#45681
Open
ArthurZucker wants to merge 1 commit intomainfrom
Open
Restore TokenizersBackend override for DeepSeek V3/R1 tokenizer dispatch#45681ArthurZucker wants to merge 1 commit intomainfrom
ArthurZucker wants to merge 1 commit intomainfrom
Conversation
…NIZER_CLASS Fixes #45488. Commit cd5bcad reordered AutoTokenizer.from_pretrained dispatch to prefer the specialized class named in tokenizer_config.json over TokenizersBackend. This silently broke the deliberate override for models in MODELS_WITH_INCORRECT_HUB_TOKENIZER_CLASS — notably the DeepSeek V3/R1 family — whose tokenizer_class field (LlamaTokenizerFast) was added to that set precisely because LlamaTokenizerFast.__init__ overwrites the ByteLevel pre-tokenizer declared in tokenizer.json with Metaspace, dropping all spaces from encode/decode round-trips. When the model_type is pinned to 'TokenizersBackend' in TOKENIZER_MAPPING_NAMES, skip the named-class branch and use TokenizersBackend directly. NLLB and other models whose mapping points to a real specialized class (the case cd5bcad targeted) are unaffected.
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45488. cd5bcad reordered AutoTokenizer dispatch to prefer the named tokenizer_class over TokenizersBackend, bypassing MODELS_WITH_INCORRECT_HUB_TOKENIZER_CLASS. DeepSeek V3/R1 round-trip lost spaces (Metaspace clobbered ByteLevel). Honor the override when the mapping is TokenizersBackend.