fix: owned_by field in GET /v1/models returns list instead of string#46006
Open
nileshpatil6 wants to merge 1 commit into
Open
fix: owned_by field in GET /v1/models returns list instead of string#46006nileshpatil6 wants to merge 1 commit into
nileshpatil6 wants to merge 1 commit into
Conversation
repo.repo_id.split("/") returns a list like ["author", "model_name"]
but owned_by expects a string. Add [0] index to extract just the author.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this fix?
In
ModelManager.get_gen_models(), theowned_byfield in the model list response was incorrectly set to a list instead of a string.str.split("/")returns a list of all segments. Without[0], theowned_byfield in theGET /v1/modelsresponse contained a Python list (e.g.["mistralai", "Mistral-7B-v0.1"]) instead of the expected author string ("mistralai"). This breaks OpenAI-compatible clients that parse the models list and expectowned_byto be a string.Changes
src/transformers/cli/serving/model_manager.py: add[0]index tosplit("/")call so only the author segment is used forowned_by.