Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: apertus, arcee, aria, cohere, cohere2, cwm, deepseek_v2, ernie4_5, eurobert, exaone4, gemma, gemma2, gemma3, glm, glm4, gpt_neox |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=46099&sha=eb018b |
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Can we remove the @ self could make sense as self.embed_tokens , not @self .
Comment on lines
+1408
to
+1410
| # "@self" in an SP plan targets the base module itself. Normalize to "" so | ||
| # downstream prefix/lookup logic treats it as the module's own FQN. | ||
| sp_plan = self.config.base_model_sp_plan or {} |
Collaborator
There was a problem hiding this comment.
this should be in the documentation of the argument not here.
Comment on lines
+1439
to
+1441
| # Empty key denotes "this child module itself" (from the "@self" sentinel); | ||
| # prefix it to just `name` so it matches the child's FQN, not "{name}.". | ||
| self._sp_plan.update({(name if k == "" else f"{name}.{k}"): v for k, v in plan.copy().items()}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.