[deepseek_v4] keep hc_head / sinks / position_bias in fp32#46198
Merged
Conversation
Issue #46167: 417 fp32 plumbing tensors get downcast to bf16 because `_keep_in_fp32_modules_strict` was missing entries for `hc_head` (top-level + MTP), `sinks` (per-attention sink token), and `position_bias` (compressor and indexer compressor). Adds the three patterns so save_pretrained preserves the source dtype for the full set of 417 tensors instead of 305.
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: deepseek_v4 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
approved these changes
May 25, 2026
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
That's quite a lot of small params being strictly fp32, is remote the same or what are they doing?
Anyways, trusting you and seems reasonable to me :D
Contributor
|
Ah seems like it only happens on save? Do we maybe have something silent like |
Collaborator
Author
|
No no I think it happens on load as well, but I'll check the original parameter dtypes to be sure! |
yuchenxie4645
pushed a commit
to yuchenxie4645/transformers
that referenced
this pull request
May 28, 2026
…ce#46198) Issue huggingface#46167: 417 fp32 plumbing tensors get downcast to bf16 because `_keep_in_fp32_modules_strict` was missing entries for `hc_head` (top-level + MTP), `sinks` (per-attention sink token), and `position_bias` (compressor and indexer compressor). Adds the three patterns so save_pretrained preserves the source dtype for the full set of 417 tensors instead of 305.
kashif
pushed a commit
to kashif/transformers
that referenced
this pull request
Jun 1, 2026
…ce#46198) Issue huggingface#46167: 417 fp32 plumbing tensors get downcast to bf16 because `_keep_in_fp32_modules_strict` was missing entries for `hc_head` (top-level + MTP), `sinks` (per-attention sink token), and `position_bias` (compressor and indexer compressor). Adds the three patterns so save_pretrained preserves the source dtype for the full set of 417 tensors instead of 305.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46167 — adds
hc_head,sinks,position_biasto_keep_in_fp32_modules_strictso the remaining 112 fp32 tensors stop being silently downcast to bf16.