Fix Gemma4 Array Mask Indexing#46203
Merged
Merged
Conversation
…sformers into petecao/fix-gemma4-indexing
Contributor
|
run-slow: gemma4 |
vasqu
approved these changes
May 26, 2026
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
This looks safe enough to me just sanity checking with our slow ci. Thanks!
Contributor
|
GH actions are not working, will recheck later 😢 |
Contributor
|
run-slow: gemma4 |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gemma4 |
Contributor
|
This comment contains models: ["models/gemma4"] |
Contributor
CI ResultsCommit Info
Model CI Report❌ 1 new failed tests from this PR 😭
|
yuchenxie4645
pushed a commit
to yuchenxie4645/transformers
that referenced
this pull request
May 28, 2026
* replae boolean indexing with torch.where * Fix consistency errors * Resolve runtime crash * Fix Python formatting --------- Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
kashif
pushed a commit
to kashif/transformers
that referenced
this pull request
Jun 1, 2026
* replae boolean indexing with torch.where * Fix consistency errors * Resolve runtime crash * Fix Python formatting --------- Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces the in-place boolean indexing assignment (llm_input_ids[multimodal_mask] = ...) with an out-of-place torch.where operation in the Gemma4 modular forward pass. This fixes a jax.errors.NonConcreteBooleanIndexError: Array boolean indices must be concrete.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?