fix(hrm_text): Add XPU Expectations for tests#46214
Merged
vasqu merged 4 commits intoMay 27, 2026
Merged
Conversation
Fixed 3 test(s): - tests/models/hrm_text/test_modeling_hrm_text.py::HrmTextModelTest::test_flash_attn_2_fp32_ln - tests/models/hrm_text/test_modeling_hrm_text.py::HrmTextIntegrationTest::test_forward_logits - tests/models/hrm_text/test_modeling_hrm_text.py::HrmTextIntegrationTest::test_greedy_generation
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
vasqu
approved these changes
May 26, 2026
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
LGTM, any reason we have it in draft?
Contributor
Author
|
Well, we found there is some minor difference between (xpu,3) and (xpu,5). We still need some time to double check if there is underlying bug on xpu side. And we need to discuss to decide if we should maintain 2 device or just (xpu,5). |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: hrm_text |
Contributor
Author
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yuchenxie4645
pushed a commit
to yuchenxie4645/transformers
that referenced
this pull request
May 28, 2026
* fix(hrm_text): auto-fix failing tests Fixed 3 test(s): - tests/models/hrm_text/test_modeling_hrm_text.py::HrmTextModelTest::test_flash_attn_2_fp32_ln - tests/models/hrm_text/test_modeling_hrm_text.py::HrmTextIntegrationTest::test_forward_logits - tests/models/hrm_text/test_modeling_hrm_text.py::HrmTextIntegrationTest::test_greedy_generation * update Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com> * update value for BMG Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com> * update Signed-off-by: kaixuan1992 <kaixuan.liu92@gmail.com> --------- Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com> Signed-off-by: kaixuan1992 <kaixuan.liu92@gmail.com> Co-authored-by: kaixuan1992 <kaixuan.liu92@gmail.com>
kashif
pushed a commit
to kashif/transformers
that referenced
this pull request
Jun 1, 2026
* fix(hrm_text): auto-fix failing tests Fixed 3 test(s): - tests/models/hrm_text/test_modeling_hrm_text.py::HrmTextModelTest::test_flash_attn_2_fp32_ln - tests/models/hrm_text/test_modeling_hrm_text.py::HrmTextIntegrationTest::test_forward_logits - tests/models/hrm_text/test_modeling_hrm_text.py::HrmTextIntegrationTest::test_greedy_generation * update Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com> * update value for BMG Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com> * update Signed-off-by: kaixuan1992 <kaixuan.liu92@gmail.com> --------- Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com> Signed-off-by: kaixuan1992 <kaixuan.liu92@gmail.com> Co-authored-by: kaixuan1992 <kaixuan.liu92@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ydshieh pls help review, thx!