Test models instantiate from default config on meta + fix failing models#46355
Open
ArthurZucker wants to merge 1 commit into
Open
Test models instantiate from default config on meta + fix failing models#46355ArthurZucker wants to merge 1 commit into
ArthurZucker wants to merge 1 commit into
Conversation
Add `test_can_be_initialized_on_meta_with_default_config` to `ModelTesterMixin`: every architecture must build from its *default* (release-scale) config on the `meta` device. The existing meta test only used the hand-tuned tiny config, which hides config-default bugs. Fixes for models that failed the new test: - `lazy_load_kernel`: degrade to the Python path on *any* hub-resolution failure (was only `FileNotFoundError`/`AssertionError`), so model init never needs the network. Fixes the whole mamba/SSM-hybrid family on `meta`/offline. - ~35 config-default fixes: `num_key_value_heads`/`head_dim` defaulting, `None` MoE sizes, `vocab_size`, special-token vs vocab size, `list`+`tuple` concat, `None` sub-config guards, `prediction_length`, default backbones, layer-type schedules, missing config fields/attributes, etc. - Two test overrides for irreducible shared-config conflicts (one config serving mutually-exclusive heads): t5gemma (enc-dec vs encoder-only) and beit (backbone contract vs semantic-segmentation `out_indices`).
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: aimv2, autoformer, aya_vision, beit, bridgetower, chameleon, convnext, convnextv2, dbrx, deepseek_ocr2, dots1, emu3, esm, focalnet, granite4_vision, hiera |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
test_can_be_initialized_on_meta_with_default_config(ModelTesterMixin): every architecture must build from its default config onmeta. Fixes ~35 models that failed — eager kernel loading on init + config-default bugs.Tested:
pytest tests/models/ -k test_can_be_initialized_on_meta_with_default_config→ all pass. AI-assisted; every line reviewed.