Skip to content

Fix typo in mm_grounding_dino converter#46390

Closed
professoralbay wants to merge 1 commit into
huggingface:mainfrom
professoralbay:main
Closed

Fix typo in mm_grounding_dino converter#46390
professoralbay wants to merge 1 commit into
huggingface:mainfrom
professoralbay:main

Conversation

@professoralbay
Copy link
Copy Markdown

Description

Fixed a straightforward typo in the weight initialization check within the mm_grounding_dino converter script. Changed "image_seperate.weight" to "image_separate.weight".

Code Agent Policy

I confirm that this PR is fully human-written and fixes a clear typographical error. No AI agents or automated bots were used to generate this contribution.

  • This pull request fixes a typo or improves the docs.
  • I speak human.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

[For maintainers] Suggested jobs to run (before merge)

run-slow: mm_grounding_dino

@Rocketknight1
Copy link
Copy Markdown
Member

Did you check that the weights being converted don't also have this typo? 😅

@professoralbay
Copy link
Copy Markdown
Author

Quick update: Just verified the checkpoints on the Hub.
The original weights indeed contain the image_seperate.weight key. To maintain backward compatibility, I am adding a fallback mechanism to the PR so it can handle both the misspelled key from existing weights and the corrected image_separate.weight key.
Tested locally with this fallback, and the model loads perfectly now. Will push the code update shortly!

@Rocketknight1
Copy link
Copy Markdown
Member

I think that's a pretty good sign that we want to keep the typo, unfortunately!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants